iOS: show compact workspace disclosure affordance#6060
Open
azooz2003-bit wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesWorkspace navigation row chevron rendering
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 20 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (20 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThis PR adds an explicit disclosure chevron to workspace rows in the compact (push) navigation style, working around a SwiftUI
Confidence Score: 5/5The change is a small, self-contained UI addition: one new computed view property, a conditional chevron image, and a well-motivated comment explaining the SwiftUI List constraint. No state, no async code, no new strings. The extraction of rowContent into an HStack is straightforward. The chevron is correctly hidden from accessibility, layout priority is set to prevent the icon from compressing WorkspaceRow, and all existing swipe/context-menu actions are untouched. No correctness issues were identified. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[WorkspaceNavigationRow.body] --> B[rowContent HStack]
B --> C[WorkspaceRow\n.layoutPriority 1]
B --> D{navigationStyle\n== .push?}
D -- yes --> E[chevron.forward\naccessibilityHidden]
D -- no --> F[nothing]
A --> G[.onTapGesture\nselectWorkspace]
A --> H[.swipeActions\nleading / trailing]
A --> I[.contextMenu]
A --> J[.accessibilityElement\nchildren combine]
Reviews (1): Last reviewed commit: "Show compact workspace row disclosure" | Re-trigger Greptile |
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavigationLink(value:)still interferes with row swipe/context delete confirmation inListListinteraction constraint next to the row contentTesting
git diff --checkxcodebuild build -workspace ios/cmux.xcworkspace -scheme cmux-ios -configuration Debug -destination 'platform=iOS Simulator,name=iPhone 17' -derivedDataPath /tmp/cmux-ios-wlnk-build PRODUCT_BUNDLE_IDENTIFIER=dev.cmux.ios.wlnkbuild PRODUCT_DISPLAY_NAME='cmux DEV wlnk' CMUX_DEV_TAG=wlnk CMUX_GIT_SHA=$(git rev-parse --short HEAD)+ EXCLUDED_SOURCE_FILE_NAMES=Info.plist CODE_SIGNING_ALLOWED=NO\n-python3 scripts/swift_file_length_budget.py --budget .github/swift-file-length-budget.tsv\n\n## Issues\n- Related: iOS: add workspace row actions #6022Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Shows a compact disclosure chevron on workspace rows in push navigation, while keeping manual tap handling to avoid SwiftUI List swipe/delete conflicts. Improves clarity in compact stacks without breaking row actions.
New Features
.push) navigation to indicate disclosure.Bug Fixes
NavigationLink(value:)with a manual tap to keep swipe/context delete confirmation working inList(documented inline).Written for commit 0e4257e. Summary will update on new commits.
Summary by CodeRabbit
Release Notes